Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated "Formatting Code Automatically" section in Readme #5019

Closed
wants to merge 1 commit into from

Conversation

karpikpl
Copy link

Moved linting packages to dev dependencies

Moved linting packages to dev dependencies
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@karpikpl karpikpl changed the title Updated "Formatting Code Automatically" section Updated "Formatting Code Automatically" section in Readme Sep 17, 2018
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@karpikpl
Copy link
Author

the build probably didn't fail because of the readme file...

@iansu
Copy link
Contributor

iansu commented Sep 18, 2018

These packages are intentionally installed as dependencies instead of dev dependencies. See: #2696

@iansu iansu closed this Sep 18, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants