Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable eval-source-map for firefox #5060

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Enable eval-source-map for firefox #5060

merged 1 commit into from
Jan 7, 2019

Conversation

jasonLaster
Copy link
Contributor

Follow up for #4930.

This enables eval-source-map for firefox browsers, which makes it possible to see mapped scopes and variables. Hopefully in a couple of months chrome will also support eval-source-map and we can drop the check.

@Timer Timer closed this Sep 26, 2018
@Timer Timer reopened this Sep 26, 2018
@gaearon gaearon closed this Nov 1, 2018
@Timer Timer changed the base branch from next to master November 1, 2018 17:11
@Timer Timer reopened this Nov 1, 2018
@stale
Copy link

stale bot commented Dec 1, 2018

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 1, 2018
@Timer
Copy link
Contributor

Timer commented Dec 1, 2018

Stale be gone!

@stale stale bot removed the stale label Dec 1, 2018
@jasonLaster
Copy link
Contributor Author

@Timer should we rebase and try to land?

It seems like chrome is unblocked...

@Timer
Copy link
Contributor

Timer commented Dec 3, 2018

Yeah, I think it's about time to switch to this by default.

@stale
Copy link

stale bot commented Jan 2, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 2, 2019
Switch to eval-source-map
09b9c2f 
Switches to eval-source-map, which is easier for webpack to recompute
when a file changes and has column based mappings, which lets firefox
devtools show original variable in the debugger and evaluate original
expressions in the console.
@jasonLaster
Copy link
Contributor Author

hmm, seeing some build errors

+yarn build
yarn run v1.14.0-20181221.0548
$ node scripts/build.js
Creating an optimized production build...
Failed to compile.
./src/index.js
Error: [BABEL] /tmp/tmp.jilV9AKxMW/test-app/src/index.js: Cannot find module '@babel/plugin-transform-react-jsx' (While processing: "/tmp/tmp.jilV9AKxMW/test-app/node_modules/babel-preset-react-app/index.js$1")
    at Array.reduce (<anonymous>)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
++set +x
e2e-simple.sh: ERROR! An error was encountered executing line 273.
Cleaning up.
yarn config v1.14.0-20181221.0548
success Set "registry" to "https://registry.yarnpkg.com".
Exiting with error.
The command "if [ $TEST_SUITE = "simple" ]; then tasks/e2e-simple.sh; fi" exited with 1.

@stale stale bot removed the stale label Jan 3, 2019
@Timer Timer added this to the 2.1.3 milestone Jan 3, 2019
@Timer
Copy link
Contributor

Timer commented Jan 3, 2019

I tagged this for next release so it stops falling through the cracks :-)

@robertvansteen
Copy link
Contributor

@jasonLaster that error is also on master. Not sure what's going on.

@ianschmitz ianschmitz modified the milestones: 2.1.3, 2.1.4 Jan 4, 2019
@ianschmitz ianschmitz closed this Jan 7, 2019
@ianschmitz ianschmitz reopened this Jan 7, 2019
@jasonLaster
Copy link
Contributor Author

jasonLaster commented Jan 7, 2019 •
edited
Loading

@ianschmitz thanks for the bump.
@Timer looks like we're 🌴

@Timer
Copy link
Contributor

Timer commented Jan 7, 2019

:shipit: YOLO

@Timer Timer merged commit 773d103 into facebook:master Jan 7, 2019
@Timer
Copy link
Contributor

Timer commented Jan 7, 2019

Thanks @jasonLaster for all the time you spent on this, including our pair-programming! It was a pleasure working with you.

mrmckeb pushed a commit to BeameryHQ/bmr-react-scripts that referenced this pull request Jan 10, 2019
@jasonLaster @Timer
Switch to eval-source-map (facebook#5060)
aa279ef 
Switches to eval-source-map, which is easier for webpack to recompute
when a file changes and has column based mappings, which lets firefox
devtools show original variable in the debugger and evaluate original
expressions in the console.
@lock lock bot locked and limited conversation to collaborators Jan 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@jasonLaster @Timer @robertvansteen @gaearon @ianschmitz @facebook-github-bot