Upgrade svgr to v2 and disable Prettier & SVGO #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4799 by @kopacki.
This updates
svgrand disables Prettier / SVGO.Prettier is disabled because it just increases compile-time latency, there's no true benefit here.
SVGO is disabled because there's no "safe defaults" that keep it useful IMO, and we don't apply optimizations to SVGs imported as URLs.
Different optimization behavior based on how the SVG is imported would be confusing/unexpected to the user, especially during debugging.
If we go down the SVGO path, we'll probably only do it for Production and for both ReactComponents and URLs.
This PR will be a great first step.