Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage advice of husky to 1.0 #5071

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Update usage advice of husky to 1.0 #5071

merged 1 commit into from
Sep 24, 2018

Conversation

martinlechner1
Copy link
Contributor

Husky had an overhaul of the API, see https://github.com/typicode/husky
Therefore the usage advice here has been adjusted.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@martinlechner1
Copy link
Contributor Author

Signed CLA.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer
Copy link
Contributor

Timer commented Sep 24, 2018

Hey! Thanks for this, but I'd rather wait until Husky is stable (v1 released instead of RCs).
What do you think?

@martinlechner1
Copy link
Contributor Author

martinlechner1 commented Sep 24, 2018

With the commands in the current guide guide the RC version is installed as well. So either there should be a warning included or the version be fixed in the command.

Edit: The current guide is not working. This is what I wanted to express.

@Timer
Copy link
Contributor

Timer commented Sep 24, 2018

Oh, I didn't realize they published the new beta as latest, this seems like an accident:

joes-mbp:create-react-app joe$ npm dist-tag ls husky
latest: 1.0.0-rc.15
next: 1.0.0-rc.14

Let's wait for a response on typicode/husky#354.

In the meantime, can you send a separate PR pinning us to 0.14.x?

@Timer
Copy link
Contributor

Timer commented Sep 24, 2018

Seems it was intentional!

@Timer
Copy link
Contributor

Timer commented Sep 24, 2018

Please move this PR to be against next and it will be accepted. 😄

@martinlechner1 martinlechner1 changed the base branch from master to next September 24, 2018 16:24
Husky had an overhaul of the API, see https://github.com/typicode/husky
Therefore the usage advice here has been adjusted.
@Timer
Copy link
Contributor

Timer commented Sep 24, 2018

Awesome!

@Timer Timer merged commit eba5995 into facebook:next Sep 24, 2018
@Timer Timer added this to the 2.0.0 milestone Sep 24, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
Husky had an overhaul of the API, see https://github.com/typicode/husky
Therefore the usage advice here has been adjusted.
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants