-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update usage advice of husky to 1.0 #5071
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Signed CLA. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Hey! Thanks for this, but I'd rather wait until Husky is stable (v1 released instead of RCs). |
With the commands in the current guide guide the RC version is installed as well. So either there should be a warning included or the version be fixed in the command. Edit: The current guide is not working. This is what I wanted to express. |
Oh, I didn't realize they published the new beta as joes-mbp:create-react-app joe$ npm dist-tag ls husky
latest: 1.0.0-rc.15
next: 1.0.0-rc.14 Let's wait for a response on typicode/husky#354. In the meantime, can you send a separate PR pinning us to |
Seems it was intentional! |
Please move this PR to be against |
Husky had an overhaul of the API, see https://github.com/typicode/husky Therefore the usage advice here has been adjusted.
Awesome! |
Husky had an overhaul of the API, see https://github.com/typicode/husky Therefore the usage advice here has been adjusted.
Husky had an overhaul of the API, see https://github.com/typicode/husky
Therefore the usage advice here has been adjusted.