Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the cache of files using Babel Macros #5078

Merged
merged 7 commits into from
Sep 25, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Sep 24, 2018

We can't cache files using babel macros until babel/babel#8497 is resolved.

Unfortunately we need to use our own loader until babel/babel-loader#687 is merged.

@Timer Timer added this to the 2.0.0 milestone Sep 24, 2018
@Timer Timer changed the title Add new overrides option Prevent the cache of files using Babel Macros Sep 24, 2018
@Timer Timer closed this Sep 24, 2018
@Timer Timer reopened this Sep 24, 2018
@Timer Timer requested a review from gaearon September 24, 2018 19:58
@Timer Timer merged commit 11737bc into facebook:next Sep 25, 2018
@Timer Timer deleted the hotfix/no-cache-macros branch September 25, 2018 00:10
caller: {
name: `babel-preset-react-app:${crypto
.randomBytes(32)
.toString('hex')}`,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why you're using a random value, but there's no need to append it to the name. You can just make a new property like craInvalidationToken or something on caller.

zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
* Add new overrides option

* Add file to package.json

* Create our own loader

* Remove overrides

* We have to use a real babel option

* Add comments
@jamesknelson jamesknelson mentioned this pull request Oct 26, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants