-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix displaying third party webpack plugins errors #5137
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Can you please give us a reproducing case that triggers this exact error? What exactly happens? |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@Timer var scriptSrc = '<%= htmlWebpackPlugin.files.chunks.main.entry %>'; By some reasons files.chunks is not defined, but I can't see this error, instead I got following error:
|
Excellent. Thank you. |
Some third party webpack plugins can generate custom single-line compiler errors without stacktrace.
For example with
html-webpack-plugin
I got following error asformatMessage
argument:'Template execution failed: TypeError: Cannot read property \'main\' of undefined'
As fast solution I propose to add empty line to avoid big changes in
formatMessage
logic.