💅 Polish webpack message output #5174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Sep 30, 2018
| exportError, | ||
| "$1 '$3' does not contain an export named '$2'." | ||
| ); | ||
| 'Run `npm i node-sass --save` or `yarn add node-sass` inside your workspace.'; |
There was a problem hiding this comment.
Do we know whether they use Yarn by presence of lockfile?
|
We should definitely follow up on each of these. We're taking on some debt here. |
|
Definitely taking on some debt, but at least it's tested. I'll file some webpack issues and cross reference them here. |
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Oct 2, 2018
* Only install react-scripts in CI mode * Link locally * Re-enable all output tests * 💄 Polish webpack output * Test sass support message * Add more tests, but disabled * Format missing default export error * Format aliased import * Why was node-sass required? Odd * Format webpack rejection error * Re-enable unknown package test * Format file not found error and catch module scope plugin error * Re-disable case sensitive paths * Intercept and format case sensitive path errors * Test out of scope message formatting * Run behavior on macOS * Run behavior on Node 8 and 10, only Node 8 for macOS * Add some debugging * Update matcher * Only check stderr * Remove old snapshot * More debug * Remove debug * Add new debug * Disable test on linux * Add comment for future
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lengths we go to for user experience...
Somewhere along the line, webpack started formatting module/file not found errors without specifying where the request came from!
We needed to intercept calls from the compilation which exposed
ModuleNotFoundErrorand edit theError's message to include relevant information.We should probably send a pull request to webpack in the future and revert this hack.
This PR also corrects a bunch of other output from common errors.