Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat .css and .sass/.scss as side effectful #5197

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Treat .css and .sass/.scss as side effectful #5197

merged 1 commit into from
Oct 1, 2018

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Oct 1, 2018

Fixes #5140. Fixes #5188.

While unfortunate due to concerns in #5188 (comment), I don't feel comfortable with webpack's default behavior until webpack adds a warning or an error for this (webpack/webpack#6571 (comment)). When webpack does, we can reconsider and go with webpack's default behavior.

I checked that this change fixes the reproducing case in https://github.com/cdaringe/will-u-load-my-styl.

@gaearon gaearon added this to the 2.0.0 milestone Oct 1, 2018
@gaearon gaearon merged commit 4a96247 into master Oct 1, 2018
@Timer Timer deleted the side-css branch October 1, 2018 14:08
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 2, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants