Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jest typeahead plugin #5213

Merged
merged 3 commits into from
Feb 10, 2019
Merged

Add Jest typeahead plugin #5213

merged 3 commits into from
Feb 10, 2019

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Oct 1, 2018 •
edited by ianschmitz
Loading

It's been separated from Jest.

I wouldn't rush though because this is glitchy:

screen shot 2018-10-01 at 10 23 53 pm

screen shot 2018-10-01 at 10 23 49 pm

Closes #6227.

@Timer Timer added this to the 2.x milestone Oct 1, 2018
@SimenB
Copy link
Contributor

SimenB commented Oct 2, 2018 •
edited
Loading

Glitchy? I haven't noticed that... Mind opening up an issue with some details?

/cc @rogeliog

@rogeliog rogeliog mentioned this pull request Oct 4, 2018
Closed
@rogeliog
Copy link
Contributor

rogeliog commented Oct 4, 2018

@gaearon Thanks for reporting!

After some investigation, I've been able to reproduce. We saw similar issues with the typeahead when it was part of Jest core, I created jest-community/jest-watch-typeahead#20 to track this. I'll work on it during the next couple of days.

@pedro-mass
Copy link

pedro-mass commented Nov 4, 2018 •
edited
Loading

If it's similar issues from before (when it was part of jest), I'd rather have the same experience over reduced features.

Or at least let us configure our own watchPlugins?

@Timer Timer mentioned this pull request Jan 20, 2019
Closed
@willdurand
Copy link

After some investigation, I've been able to reproduce. We saw similar issues with the typeahead when it was part of Jest core, I created jest-community/jest-watch-typeahead#20 to track this. I'll work on it during the next couple of days.

I see a new version of this plugin has been released with a fix for what's quoted above. Can we move forward with this PR now? Thanks ❤️

@ianschmitz ianschmitz modified the milestones: 2.x, 2.1.4 Feb 10, 2019
@ianschmitz ianschmitz merged commit 782d71b into master Feb 10, 2019
@ianschmitz ianschmitz deleted the typeahead branch February 10, 2019 16:13
mrmckeb pushed a commit to BeameryHQ/bmr-react-scripts that referenced this pull request Feb 11, 2019
@gaearon @ianschmitz
Add Jest typeahead plugin (facebook#5213)
c770726 
* Add Jest typeahead plugin

* Update jest-watch-typeahead to 0.2.1
@lock lock bot locked and limited conversation to collaborators Feb 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.
8 participants
@gaearon @SimenB @rogeliog @pedro-mass @willdurand @Timer @ianschmitz @facebook-github-bot