Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SoMe links to documentation #5251

Merged
merged 6 commits into from
Oct 4, 2018

Conversation

selbekk
Copy link
Contributor

@selbekk selbekk commented Oct 2, 2018

This pull request adds some more relevant links than the boilerplate ones provided by Docusaurus by default.

Addresses #5238

@selbekk
Copy link
Contributor Author

selbekk commented Oct 2, 2018

Feel free to disagree on some of these - I don't mind removing / changing them

@selbekk selbekk mentioned this pull request Oct 2, 2018
20 tasks
@Timer Timer added this to the 2.0.4 milestone Oct 2, 2018
@Timer
Copy link
Contributor

Timer commented Oct 2, 2018

These are fine. Can we drop Discord and replace it with Spectrum or something?

https://spectrum.chat/react

@selbekk
Copy link
Contributor Author

selbekk commented Oct 2, 2018

Sure! :-) i’ll get it done sometime tonight :-)

@Timer Timer modified the milestones: 2.0.4, 2.x Oct 3, 2018
@selbekk selbekk changed the base branch from master to docusaurus October 4, 2018 06:17
@selbekk selbekk force-pushed the 5238-add-some-links branch from 23beb04 to e522afd Compare October 4, 2018 06:19
@selbekk
Copy link
Contributor Author

selbekk commented Oct 4, 2018

okay, that was some major Git-fu I just pulled off there. 💯 With any luck, this will fix the travis build as well, which failed for inexplicable reasons. Should be ready for review now, @amyrlam

Copy link
Contributor

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@selbekk
Copy link
Contributor Author

selbekk commented Oct 4, 2018

hm so I guess go ahead and merge at will @Timer / @gaearon ? 👍

@Timer Timer merged commit c2a163a into facebook:docusaurus Oct 4, 2018
@selbekk selbekk deleted the 5238-add-some-links branch October 4, 2018 12:35
nate770 pushed a commit to ONTW/create-react-app that referenced this pull request Oct 30, 2018
* Add GitHub link to header

* Add GitHub link to footer

* Add link to Stack Overflow

* Add Twitter link

* Add the repoUrl prop to the siteConfig

* Switch out Discord with Spectrum
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants