[create-react-app] avoid copying cached yarn.lock for custom scripts #5298
Conversation
per discussion in #5270, do not copy cached `yarn.lock` file if `--scripts-version=[custom-package/version]` is provided. May this save us weird PRs ("your lockfile is breaking my package") in the future... :)
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Hmm, this looks like it would disable the lock file when someone specifies any version, meaning a different version of react-scripts. This behavior should only occur if the person is actually changing the installed package from 'react-scripts'. |
custom react-scripts versions still get cached lock file
|
adjusted. 👍 |
|
@gaearon you said you wouldn't mind, but the PR got left behind... any chance you could review this? :) |
|
ping? |
|
In the case where the user's registry is not |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
per discussion in #5270, do not copy cached
yarn.lockfile if--scripts-version=[custom-package]is provided.May this save us weird PRs ("your lockfile is breaking my package") in the future... :)