Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused require for getCacheIdentifier after ejecting #5317

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

benbrandt
Copy link
Contributor

I ejected a test project to take a look at the final webpack configs for some inspiration (our app has some custom needs, but I love looking at your configs for ideas!), and noticed that there was an unused import at the top of the file after ejecting.

Below is a screenshot after I ran the following from the root of the repo:

yarn create-react-app my-app
cd my-app
yarn eject

screen shot 2018-10-05 at 9 51 00 am

Let me know if you need anything else from me or if there is a better way to handle this!

@Timer Timer added this to the 2.0.5 milestone Oct 5, 2018
@Timer
Copy link
Contributor

Timer commented Oct 5, 2018

Whoops, thanks!

@Timer Timer merged commit 183efed into facebook:master Oct 5, 2018
@benbrandt
Copy link
Contributor Author

Awesome! Glad I could help!

zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants