-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added note on update to .flowconfig for .scss imports #5321
Conversation
Added a note aimed at Flow users on how to get Flow to recognize the .scss imports.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
@@ -598,6 +598,13 @@ This will allow you to do imports like | |||
|
|||
> **Note:** You must prefix imports from `node_modules` with `~` as displayed above. | |||
|
|||
> **Note:** If you're using Flow, add the following to your .flowconfig so it'll recognize the .scss import. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include .sass
as well, and wrap these in the inline code back ticks please: `.scss` (and .flowconfig
).
Can you please make the code snippet inside of the quote?
Did you try this with css modules? I found I had to do this: where CSSModule.js.flow is:
otherwise I get:
|
* Added note on update to .flowconfig for .scss imports Added a note aimed at Flow users on how to get Flow to recognize the .scss imports. * Mentioned .sass extension in note, added backticks
Added a note aimed at Flow users on how to get Flow to recognize the .scss imports.