-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment variable to optionaly disable inlining of chunks #5354
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Let's call it |
Also, please add this to the Advanced Configuration section in the documentation (User Guide). |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Done and done. Let me know if the docs aren't correct, the emoji's for dev/prod were a little confusing. I assume a cross means it doesn't get listened to in that environment, and a tick means it does? |
Thanks, you got it! |
…ebook#5354) * Add environment variable to optionaly disable inlining of chunks * Changed env var to `process.env.INLINE_RUNTIME_CHUNK ` * Added env var to Advanced Configuration in docs * Drop implied behavior * Tweak working to match other descriptions
Adds the environment variable
INLINE_CHUNK
, which when set tofalse
will disable the automatic inlining of the runtime chunk into the outputtedindex.html
file.As per discussion in #5309.