Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if config callbacks are defined before using them (next) #5368

Closed
wants to merge 1 commit into from
Closed

Check if config callbacks are defined before using them (next) #5368

wants to merge 1 commit into from

Conversation

piotr-cz
Copy link
Contributor

@piotr-cz piotr-cz commented Oct 9, 2018

This resolves bug introduced and reported in #3867:

Before invoking callbacks onUpdate and onSuccess, there should be check to make sure that config object has been passed to service worker at all.

@piotr-cz piotr-cz mentioned this pull request Oct 9, 2018
Merged
@piotr-cz piotr-cz changed the title Check if config callbacks are defined before using them Check if config callbacks are defined before using them (next) Oct 9, 2018
@piotr-cz
Copy link
Contributor Author

piotr-cz commented Oct 9, 2018

Travis fails with message: lerna ERR! Error: fatal: No tags can describe '1feca43dbdba5f21e52acb629a601870a4d0a0dc'..

@Timer Timer changed the base branch from next to master October 9, 2018 12:19
@Timer
Copy link
Contributor

Timer commented Oct 9, 2018

Fix was fixed previously via #5301, thanks!

@Timer Timer closed this Oct 9, 2018
@piotr-cz
Copy link
Contributor Author

piotr-cz commented Oct 9, 2018

Thanks, I didn't notice. However this one is for next branch

@piotr-cz piotr-cz changed the base branch from master to next October 9, 2018 13:41
@piotr-cz
Copy link
Contributor Author

piotr-cz commented Oct 9, 2018

Okay, I've changed base branch from master to next (I was sure I've done when opening PR)

@Timer
Copy link
Contributor

Timer commented Oct 9, 2018 •
edited
Loading

next isn't a valid branch anymore. We're back on master, I had switched it for you.

@piotr-cz
Copy link
Contributor Author

piotr-cz commented Oct 9, 2018

Thanks, I didn't know

@piotr-cz piotr-cz deleted the bugfix/sw-callbacks branch October 9, 2018 20:12
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotr-cz @Timer @facebook-github-bot