Updated the link to firebase hosting #5710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
xs9627
pushed a commit
to xs9627/create-react-app
that referenced
this pull request
Nov 12, 2018
* facebook-master: (578 commits) Add PR welcoming badge (facebook#5759) Suggest Encore when not building a SPA with Symfony (facebook#5730) Merge webpack configuration (facebook#5722) Tweak bot settings Update stale.yml Fix typo (facebook#5727) Version bump postcss-preset-env to latest (facebook#5721) Updated the link to firebase hosting (facebook#5710) Fixed link to manifest.json file (facebook#5704) Fix broken documentation link (facebook#5670) Fix tsconfig.json lib suggested value (facebook#5701) Add permissive TS lib defaults (facebook#5694) Lock issues more aggressively Make stale bot configuration more aggressive ignore intellij module files when generating an app (facebook#4605) update envinfo to 5.11.1 (facebook#5685) Add bot config (facebook#4483) Publish Update cached lock file Add changelog for 2.1.1 ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firebase link was targeting Firebase JS SDK which is not correct for this part of the documentation. This section of the documentation is trying to outline various deployment methods, Firebase JS SDK has nothing to do with deployment. Instead, the link should be pointing to Firebase Hosting Docs.
Same as #5348, except with the correct file modification.