Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information for usage custom registries on e2e testing #4488 #5767

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Add information for usage custom registries on e2e testing #4488 #5767

merged 1 commit into from
Feb 11, 2019

Conversation

juanpicado
Copy link
Contributor

Hi, this PR provide more information about how to modify the custom registry configuration to running E2E test.

Refers to: #4488

@Timer
Copy link
Contributor

Timer commented Nov 12, 2018

This should probably be in the root-level CONTRIBUTING.md, it has no bearing to react-scripts.

@juanpicado
Copy link
Contributor Author

Agree, if the text is ok for you. I'd suggest the following structure.

screen shot 2018-11-12 at 5 41 16 am

@ayusharma
Copy link

Nice work @juanpicado 👏

@juanpicado juanpicado mentioned this pull request Dec 10, 2018
Closed
@stale
Copy link

stale bot commented Dec 12, 2018

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 12, 2018
@juanpicado
Copy link
Contributor Author

Just waiting for this to be merge or any further instructions :)

@stale stale bot removed the stale label Dec 12, 2018
@stale
Copy link

stale bot commented Jan 12, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 12, 2019
@juanpicado
Copy link
Contributor Author

🕐 ... 🚶 ... 🤖

@stale stale bot removed the stale label Jan 12, 2019
@stale
Copy link

stale bot commented Feb 11, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Feb 11, 2019
@juanpicado
Copy link
Contributor Author

🥁

@stale stale bot removed the stale label Feb 11, 2019
@Timer Timer merged commit c6eca6e into facebook:master Feb 11, 2019
@Timer
Copy link
Contributor

Timer commented Feb 11, 2019

❤️ thanks

@lock lock bot locked and limited conversation to collaborators Feb 16, 2019
@iansu iansu added this to the 2.1.6 milestone Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BumbuKhan BumbuKhan BumbuKhan approved these changes

Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
2.1.6
Development

Successfully merging this pull request may close these issues.
6 participants
@juanpicado @Timer @ayusharma @BumbuKhan @iansu @facebook-github-bot