Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest a different default for speed reasons #5959

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Dec 4, 2018

Advanced users can opt into this behavior, but it's generally outside the users' control to fix and comes with performance concerns

Advanced users can opt into this behavior, but it's generally outside the users' control to fix and comes with performance concerns
@Timer Timer added this to the 2.1.2 milestone Dec 4, 2018
@netlify
Copy link

netlify bot commented Dec 4, 2018

Deploy preview for gallant-davinci-8f9bd9 ready!

Built with commit 23fc36b

https://deploy-preview-5959--gallant-davinci-8f9bd9.netlify.com

@Timer Timer merged commit c50a7ea into facebook:master Dec 4, 2018
@Timer Timer deleted the ts-speed branch December 4, 2018 15:58
timsnadden added a commit to timsnadden/create-react-app that referenced this pull request Dec 7, 2018
* master: (39 commits)
  Added extension to .eslintrc (facebook#5988)
  Update links to docs in all package README files (facebook#5912)
  Use https for linked images in docs to fix mixed content warnings (facebook#5985)
  Improve error messaging in verifyPackageTree.js (facebook#5974)
  Add removeItem to localStorage mock in docs (facebook#5919)
  Add SASS_PATH instructions to Sass docs (facebook#5917)
  Suggest a different default for speed reasons (facebook#5959)
  Add pre-eject message about new features in v2 (facebook#5954)
  Add netlify.toml to prepare for deploy to netlify facebook#5807 (facebook#5930)
  Correct some comments (facebook#5927)
  Add note to docs about using Sass and Flow together (facebook#5823)
  Update PWA link in README (facebook#5907)
  Add placeholders to template README for bit.ly links. (facebook#5808)
  Disable copy to clipboard in cra --info (facebook#5905)
  Support setupTests.ts (facebook#5698)
  Remove unnecessary whitespace in template HTML
  Run prettier on HTML files (facebook#5839)
  Some Grammar fixes (facebook#5858)
  Fix link to page about running tests (facebook#5883)
  fix: make typescriptformatter support 0.5 of fork checker (facebook#5879)
  ...
mrmckeb pushed a commit to BeameryHQ/bmr-react-scripts that referenced this pull request Dec 20, 2018
Advanced users can opt into this behavior, but it's generally outside the users' control to fix and comes with performance concerns
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants