Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add webp support for typescript #5978

Merged
merged 2 commits into from
Dec 11, 2018

Conversation

dugagjin
Copy link
Contributor

@dugagjin dugagjin commented Dec 6, 2018

webp file support was added in #458 but the typescript declaration for webp was missing.

webp images couldn't be used with typescript.

This pull request fixes this by adding a webp typescript declaration.

@netlify
Copy link

netlify bot commented Dec 6, 2018

Deploy preview for create-react-app ready!

Built with commit af5dd9b

https://deploy-preview-5978--create-react-app.netlify.com

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz
Copy link
Contributor

Do you mind moving this up below *.png?

@dugagjin
Copy link
Contributor Author

dugagjin commented Dec 7, 2018

Done.

@Timer Timer added this to the 2.1.2 milestone Dec 11, 2018
@Timer
Copy link
Contributor

Timer commented Dec 11, 2018

Thanks!

@Timer Timer merged commit 3d1c0ea into facebook:master Dec 11, 2018
@dugagjin dugagjin deleted the typescript-webp-support branch December 12, 2018 07:58
hisapy pushed a commit to iporaitech/create-react-app that referenced this pull request Dec 14, 2018
* add webp support for typescript

* moved webp declaration below png
mrmckeb pushed a commit to BeameryHQ/bmr-react-scripts that referenced this pull request Dec 20, 2018
* add webp support for typescript

* moved webp declaration below png
@lock lock bot locked and limited conversation to collaborators Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants