Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deployment instructions with AWS Amplify #6208

Merged
merged 7 commits into from
Mar 21, 2019
Merged

Add deployment instructions with AWS Amplify #6208

merged 7 commits into from
Mar 21, 2019

Conversation

swaminator
Copy link
Contributor

@swaminator swaminator commented Jan 15, 2019 •
edited
Loading

Added instructions on how to deploy a CRA app with AWS Amplify.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@swaminator
Copy link
Contributor Author

Hi - now that the CLA has been signed, would appreciate feedback on this PR. Thanks!

@swaminator
Copy link
Contributor Author

@npverni @saimonmoore Please review this PR and let me know if it can be merged. Thanks!

@swaminator
Copy link
Contributor Author

Following up again with more folks @mg. Can we please review this PR? Thanks.

@mg
Copy link
Contributor

mg commented Feb 1, 2019

I don't understand why I am being included in this, surely you mean to tag someone else?

@swaminator
Copy link
Contributor Author

Apologies for the tag (you showed up when I typed out the message in the editor box). I'm looking for someone to review my PR so it can get merged. Haven't had too much luck getting anyone to respond in the past week.

@stale
Copy link

stale bot commented Mar 4, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Mar 4, 2019
@iansu iansu removed the stale label Mar 4, 2019
@iansu iansu self-assigned this Mar 4, 2019
@iansu iansu requested a review from amyrlam March 4, 2019 06:12
@swaminator
Copy link
Contributor Author

Hi @iansu, I'd love for this PR to be reviewed and accepted.

@swaminator
Copy link
Contributor Author

@amyrlam Can you please review this PR? It's been 2 months.

iansu
iansu suggested changes Mar 19, 2019
View reviewed changes
docusaurus/docs/deployment.md Outdated Show resolved Hide resolved
docusaurus/docs/deployment.md Outdated Show resolved Hide resolved
docusaurus/docs/deployment.md Outdated Show resolved Hide resolved
iansu and others added 3 commits March 20, 2019 16:47
@iansu @swaminator
Update docusaurus/docs/deployment.md
0526a2f 
create-react-app to Create React App

Co-Authored-By: swaminator <nikhil@live.ca>
@iansu @swaminator
Update docusaurus/docs/deployment.md
8b68e76 
Removed extra verbiage.

Co-Authored-By: swaminator <nikhil@live.ca>
@swaminator
Removed GIF
27ff346
@swaminator
Copy link
Contributor Author

@iansu all requested changes are made.

@iansu iansu added this to the 3.0 milestone Mar 21, 2019
@iansu iansu merged commit 5c637a4 into facebook:master Mar 21, 2019
@iansu
Copy link
Contributor

iansu commented Mar 21, 2019

Looks good. Thanks!

@swaminator
Copy link
Contributor Author

Thanks @iansu. I just visited the webpage and don't see the docs yet. Is there a delay for propagation?

@iansu
Copy link
Contributor

iansu commented Mar 21, 2019

Yes, we generally only publish the docs after each release.

@lock lock bot locked and limited conversation to collaborators Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iansu iansu iansu requested changes

@amyrlam amyrlam Awaiting requested review from amyrlam

Assignees

@iansu iansu

Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@swaminator @facebook-github-bot @mg @iansu