Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent cursor events on app-logo svg #6276

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

kostadriano
Copy link
Contributor

This PR fix #6273.

Prevent any cursor event on React logo, any component below can be clicked now. The images below show the border of logo.

image

image

I think is not really necessary change the SVG logo or put it directly in the code.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer Timer added this to the 2.1.4 milestone Jan 25, 2019
@Timer
Copy link
Contributor

Timer commented Jan 25, 2019

LGTM, thanks!

@Timer Timer merged commit 714599d into facebook:master Jan 25, 2019
@kostadriano kostadriano deleted the fix/logo-size branch January 28, 2019 16:52
@lock lock bot locked and limited conversation to collaborators Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlap invisible part of the logo
3 participants