Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Terser function inlining #6295

Closed
wants to merge 1 commit into from

Conversation

jfo84
Copy link

@jfo84 jfo84 commented Jan 28, 2019

There's a bug in a library I contribute to that is causing us a lot of trouble. There's plenty of documentation of the bug, and we can reliably reproduce it in our production app. Can you disable this behavior here to help out one of our users?

@Downchuck
Copy link
Contributor

The link on Terser JS shows the issue as being fixed -- have you sent them a note to investigate as well?

@jfo84
Copy link
Author

jfo84 commented Jan 30, 2019

@Downchuck Which link? There's an open issue on Terser that you can find in the linked issue

@Downchuck
Copy link
Contributor

@jfo84 My mistake - I saw a note already in the CRA code to a closed issue terser/terser#120 - In your post you're working a different issue terser/terser#244

@jfo84
Copy link
Author

jfo84 commented Jan 31, 2019

@Downchuck You are a bull in a china shop, my friend

@Downchuck
Copy link
Contributor

@jfo84 If you're gonna make an omelette, you gotta break a few dishes.

@jfo84
Copy link
Author

jfo84 commented Jan 31, 2019

@Downchuck I respect that

@stale
Copy link

stale bot commented Mar 2, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Mar 2, 2019
@stale
Copy link

stale bot commented Mar 7, 2019

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@stale stale bot closed this Mar 7, 2019
@lock lock bot locked and limited conversation to collaborators Mar 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants