Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove body padding reset from templates #6300

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Remove body padding reset from templates #6300

merged 2 commits into from
Apr 24, 2019

Conversation

Hurtak
Copy link
Contributor

@Hurtak Hurtak commented Jan 29, 2019

AFAIK reseting padding is useless since there is no padding on body in browser default styles
https://www.w3schools.com/cssref/css_default_values.asp

@stale
Copy link

stale bot commented Feb 28, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Feb 28, 2019
@Hurtak Hurtak closed this Feb 28, 2019
@Hurtak Hurtak reopened this Feb 28, 2019
@stale stale bot removed stale labels Feb 28, 2019
@stale
Copy link

stale bot commented Apr 23, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Apr 23, 2019
@Hurtak
Copy link
Contributor Author

Hurtak commented Apr 24, 2019

Ping

@stale stale bot removed the stale label Apr 24, 2019
@mrmckeb
Copy link
Contributor

mrmckeb commented Apr 24, 2019

Hi @Hurtak, you're correct and I've confirmed with some independent research. I've also noted that this is not included in normalize.css.

@mrmckeb mrmckeb changed the title remove padding 0 on body from default styles Remove body padding reset from templates Apr 24, 2019
@iansu iansu added this to the 3.0.1 milestone Apr 24, 2019
@iansu iansu merged commit 73d5579 into facebook:master Apr 24, 2019
@iansu
Copy link
Contributor

iansu commented Apr 24, 2019

Thanks!

@Hurtak Hurtak deleted the patch-2 branch April 25, 2019 07:59
@lock lock bot locked and limited conversation to collaborators Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ianschmitz ianschmitz ianschmitz approved these changes

@mrmckeb mrmckeb mrmckeb approved these changes

@amyrlam amyrlam Awaiting requested review from amyrlam

@bugzpodder bugzpodder Awaiting requested review from bugzpodder

@gaearon gaearon Awaiting requested review from gaearon

@iansu iansu Awaiting requested review from iansu

@petetnt petetnt Awaiting requested review from petetnt

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@Hurtak @mrmckeb @iansu @ianschmitz @facebook-github-bot