Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel-plugin-macros 2.4.4 -> 2.4.5 #6307

Merged
merged 1 commit into from
Feb 9, 2019

Conversation

maniax89
Copy link
Contributor

As part of the latest babel-plugin-macros 2.4.5 release, there was a small fix that went in that fixes a bug specifying the babelMacros entry in package.json no longer working. This patch version increase should remedy the issue and allow specifying babel macro configuration in the package.json file again (as stated in the user docs of babel-plugin-macros)

As part of the latest babel-plugin-macros [2.4.5 release](https://github.com/kentcdodds/babel-plugin-macros/releases/tag/v2.4.5), there was a small fix that went in that fixes a [bug](kentcdodds/babel-plugin-macros#100) specifying the `babelMacros` entry in `package.json` no longer working. This patch version increase should remedy the issue and allow specifying babel macro configuration in the `package.json` file again (as stated in the [user docs](https://github.com/kentcdodds/babel-plugin-macros/blob/master/other/docs/user.md#config-experimental) of babel-plugin-macros)
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@maniax89
Copy link
Contributor Author

seems like this step is failing in the build:

$ react-scripts start --smoke-test
internal/modules/cjs/loader.js:613
    throw err;
    ^
Error: Cannot find module 'react-dev-utils/crossSpawn'

initiated via
if [ $TEST_SUITE = "installs" ]; then tasks/e2e-installs.sh; fi

^not sure if this is related to this PR though

@maniax89
Copy link
Contributor Author

maniax89 commented Feb 8, 2019

any updates on this? is there something I can do to help move this forward?

@ianschmitz ianschmitz added this to the 2.1.4 milestone Feb 9, 2019
@ianschmitz ianschmitz merged commit 42ed676 into facebook:master Feb 9, 2019
@ianschmitz
Copy link
Contributor

ianschmitz commented Feb 9, 2019

seems like this step is failing in the build:
not sure if this is related to this PR though

We're having some issues with flaky builds right now. The same is happening on master.

Thanks for the PR!

@lock lock bot locked and limited conversation to collaborators Feb 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants