Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semicolons in the ProcessEnv interface #6364

Conversation

DominikPalo
Copy link
Contributor

Interface members should be terminated with semicolons. I've made this change to be consistent with other interfaces in the create-react-app project and also to fulfil a widely used TSLint rule semicolon.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz added this to the 2.1.4 milestone Feb 8, 2019
@ianschmitz ianschmitz merged commit caf0a30 into facebook:master Feb 8, 2019
@ianschmitz
Copy link
Contributor

Thanks!

mrmckeb pushed a commit to BeameryHQ/bmr-react-scripts that referenced this pull request Feb 11, 2019
@lock lock bot locked and limited conversation to collaborators Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants