fix: add fork-ts-plugin as a dependency

[elevatebart]

previously referenced but not dependent.
closes #6400

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[ghost]

I think this is a bad idea. I don't use TS, why should I install this plugin?

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[elevatebart]

Hey @demkovych, I see your point.
What do you suggest as a solution?
Remove @deftomat optimization?
Create a plugin system?

[ghost]

@elevatebart I don't know. As i see, we can't use fork-ts-checker-webpack-plugin without typescript installed. Maybe will be better to move this plugin to devDevendencies and move plugin import under https://github.com/deftomat/create-react-app/blob/321d960a67ad3dba8633adfe3292f14c281db7d8/packages/react-dev-utils/WebpackDevServerUtils.js#L141 ?

[elevatebart]

The problem of the dependency issue will still occur if someone is using typescript, without having this plugin as an explicit dependency, react-dev-utils will break again.

This eslint rule would have caught this issue

[ghost]

Or rollback to "react-dev-utils": "7.0.1"

[elevatebart]

That was my reflex too. Hope someone checks here soon.

[deftomat]

My apologies guys. That's the "classic" monorepo issue. I forgot to add it into dependencies. 😞

[deftomat]

Looks like #6395 is a better approach.

[ianschmitz]

Hey just looking into this now.

[elevatebart]

It still adds the ts-checker dependency to people without typescript... Oh well...

[ianschmitz]

We decided to revert #5903 to fix react-dev-utils for downstream consumers. This will give us a bit of time to figure out the best solution for how to consume the fork-ts-checker-webpack-plugin dependency.

2.1.5 is now available

[johnnyreilly]

Heya,

I can see that #6395 has been merged but it also says here that #5903 was reverted.

Could you clarify where are things now please? I'm keen to get the improved TypeScript experience out there in a way that doesn't impede people who don't want to use TypeScript...