Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved language used in markdown code blocks. #6419

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Improved language used in markdown code blocks. #6419

merged 2 commits into from
Feb 22, 2019

Conversation

cherouvim
Copy link
Contributor

Went through all code blocks in the markdown files are did the following:

  • Added appropriate language on all plain code blocks (starting with plain ```). Added mostly sh, json and yaml.
  • Changed a couple of js to json.
  • Changed a couple of bash to sh for consistency.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

amyrlam
amyrlam reviewed Feb 21, 2019
View reviewed changes
docusaurus/website/README.md Outdated
@@ -16,6 +16,7 @@ This website was created with [Docusaurus](https://docusaurus.io/).
# Install dependencies
$ yarn
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you remove this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. Yes, I think I did it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, did you mean that I should remove line 19, or revert the whole file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion! Yeah just to remove the new line that you added to docusaurus/website/README.md by accident... looks good now thanks!

amyrlam
amyrlam approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amyrlam amyrlam merged commit 7ec3647 into facebook:master Feb 22, 2019
@lock lock bot locked and limited conversation to collaborators Feb 27, 2019
@iansu iansu added this to the 2.1.6 milestone Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyrlam amyrlam amyrlam approved these changes

@bugzpodder bugzpodder Awaiting requested review from bugzpodder

@gaearon gaearon Awaiting requested review from gaearon

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
2.1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@cherouvim @facebook-github-bot @amyrlam @iansu @ianschmitz