Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directory details to packages/* package.json #6589

Closed
wants to merge 1 commit into from
Closed

Add directory details to packages/* package.json #6589

wants to merge 1 commit into from

Conversation

feelepxyz
Copy link
Contributor

Specifying the directory as part of the repository field in a
package.json allows third party tools to provide better support when
working with monorepos. For example, it allows them to correctly
construct a commit diff for a specific package.

This format was accepted by npm in npm/rfcs#19.

Specifying the directory as part of the repository field in a
package.json allows third party tools to provide better support when
working with monorepos. For example, it allows them to correctly
construct a commit diff for a specific package.

This format was accepted by npm in npm/rfcs#19.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Apr 6, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Apr 6, 2019
@iansu iansu removed the stale label Apr 7, 2019
@iansu iansu self-assigned this Apr 7, 2019
@iansu iansu added this to the 3.0 milestone Apr 16, 2019
@iansu iansu closed this Apr 16, 2019
@iansu
Copy link
Contributor

iansu commented Apr 16, 2019

Oops, I was going to close and reopen this to rerun the tests but it seems the original repo the PR was submitted from has been deleted.

@feelepxyz Can you resubmit this? If you can't I'll do it but I'd prefer you get credited for it.

@feelepxyz
Copy link
Contributor Author

@iansu hey just pushed a new fork #6826

@lock lock bot locked and limited conversation to collaborators Apr 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants