Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill verdaccio in CI tasks cleanup #6700

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Kill verdaccio in CI tasks cleanup #6700

merged 1 commit into from
Mar 26, 2019

Conversation

santoshyadavdev
Copy link
Contributor

@santoshyadavdev santoshyadavdev commented Mar 21, 2019 •
edited by ianschmitz
Loading

Fixes #6663.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz changed the title bug: Kill verdaccio in CI tasks cleanup Kill verdaccio in CI tasks cleanup Mar 22, 2019
@ianschmitz
Copy link
Contributor

Looks like that worked!

https://travis-ci.org/facebook/create-react-app/jobs/509467770#L1827

Can you update our other e2e scripts that use verdaccio with the same cleanup logic?

@ianschmitz ianschmitz self-assigned this Mar 22, 2019
@santoshyadavdev
Copy link
Contributor Author

Looks like that worked!

https://travis-ci.org/facebook/create-react-app/jobs/509467770#L1827

Can you update our other e2e scripts that use verdaccio with the same cleanup logic?

Done, waiting for build.

@santoshyadavdev
Copy link
Contributor Author

@ianschmitz ,
The changes worked for other task as well. Let me know if we need any other changes.

ianschmitz
ianschmitz reviewed Mar 22, 2019
View reviewed changes
tasks/e2e-old-node.sh Outdated Show resolved Hide resolved
@santoshyadavdev
Copy link
Contributor Author

Hi @ianschmitz ,

Let me know if any changes are needed.

@ianschmitz ianschmitz added this to the 3.0 milestone Mar 26, 2019
@ianschmitz ianschmitz merged commit 5acb286 into facebook:master Mar 26, 2019
@ianschmitz
Copy link
Contributor

Looks good. Thanks @santoshyadav198613

@lock lock bot locked and limited conversation to collaborators Mar 31, 2019
@santoshyadavdev santoshyadavdev deleted the bug--Kill-verdaccio-in-CI-tasks-cleanup branch October 19, 2021 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ianschmitz ianschmitz ianschmitz left review comments

Assignees

@ianschmitz ianschmitz

Labels
CLA Signed tag: internal
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@santoshyadavdev @facebook-github-bot @ianschmitz