Remove project property from @typescript-eslint/parser options #6701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwilsdon
requested review from
Timer,
amyrlam,
bugzpodder,
gaearon,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
We also have logic at the top of this file that is specific to the typescript project settings: https://github.com/facebook/create-react-app/blob/1f4516dd714732c00d1c3d02f9e3a3a495b3f608/packages/eslint-config-react-app/index.js#L26-L34. |
The "project" property has a significant performance impact on linting, and none our rules currently need it. Fixes #6661.
|
Oops, missed those! I've removed them now 👍 |
|
I removed some unnecessary code that was added for the |
ianschmitz
approved these changes
Mar 24, 2019
|
Oops, missed those too 😖 cheers |
Idered
added a commit
to eyedea-io/create-react-app
that referenced
this pull request
Apr 1, 2019
Remove project property from @typescript-eslint/parser options (facebook#6701)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "project" property has a significant performance impact on linting,
and none our rules currently need it.
Fixes #6661.