-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the configuration for PnP/Typescript #6856
Conversation
Fast work! Question: I don't see usage of the https://github.com/arcanis/pnp-webpack-plugin in this PR. Is use of the pnp-webpack-plugin no longer required when working with webpack? |
Until webpack/enhanced-resolve#168 gets merged the In the case of TypeScript, since it uses its own resolution instead of |
Thanks @arcanis. Does Jest work as expected with this PR? |
Yep - running As far as I can remember, Jest just uses Babel to strip the TS types, so no particular TS resolution involved - it simply uses the classic Jest resolution (which supports PnP out of the box since 24.5). |
Can't wait for this aha |
Any blocker? |
No, I think this looks good. Thanks for the reminder. 😀 |
Thanks! ❤️ |
The
fork-ts-checker-webpack-plugin
package just released an update that allows to specify custom resolution schemes. This makes it possible for Create-React-App to have native PnP support even when using TypeScript.I've tested this diff locally and it seemed to work.