Update eslint-plugin-react and enable new rules #696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some new rules had been added that are a good fit for this project. All of these are either already runtime warnings in React (no-danger-with-children, style-prop-object) or React features that are going to be deprecated in the future (no-find-dom-node). The new rules:
react/no-danger-with-children
(Rule proposal: prevent both children and dangerouslySetInnerHTML at the same time jsx-eslint/eslint-plugin-react#710)react/no-find-dom-node
(Rule proposal: warn against using findDOMNode() jsx-eslint/eslint-plugin-react#678)react/style-prop-object
(Rule proposal: ensure style prop on DOM element tags is an object jsx-eslint/eslint-plugin-react#715)