Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix the e2e test #704

Merged
merged 1 commit into from
Sep 22, 2016
Merged

Conversation

fson
Copy link
Contributor

@fson fson commented Sep 22, 2016

Only copy our own packages to bundledDependencies in the e2e test.

We previously (#699) added bundling all the dependencies to the e2e test, but this can crash Travis (#701), when it runs out of memory trying to bundle them.

Only copy our own packages to bundledDependencies in the e2e test
@ghost ghost added the CLA Signed label Sep 22, 2016
@fson
Copy link
Contributor Author

fson commented Sep 22, 2016

Failed in Travis first, but passed after I cleared the cache.

@gaearon gaearon merged commit 302b9ec into facebook:master Sep 22, 2016
@fson fson deleted the e2e-bundled-deps branch September 22, 2016 21:32
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
Only copy our own packages to bundledDependencies in the e2e test
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants