Eject .babelrc instead of separate configs #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Could .babelrc live in the For example, if we created a |
|
After ejecting, it is moved to the root folder of your app. |
cpojer
reviewed
Sep 22, 2016
| const babelJest = require('babel-jest'); | ||
|
|
||
| module.exports = babelJest.createTransformer(babelDev); | ||
| module.exports = babelJest.createTransformer({ | ||
| presets: [require.resolve('babel-preset-react-app')] |
There was a problem hiding this comment.
you don't really need this transformer any more. If you are creating a .babelrc, you can just use babel-jest directly by making it an explicit dependency and Jest will pick up the babelrc file.
cpojer
reviewed
Sep 22, 2016
| @@ -35,5 +34,10 @@ module.exports = (resolve, rootDir) => { | |||
| if (rootDir) { | |||
| config.rootDir = rootDir; | |||
| } | |||
| if (!isEjecting) { | |||
| // This is unnecessary after ejecting because Jest | |||
|
Works locally, and e2e has a problem anyway: #707. |
This was referenced Sep 22, 2016
Closed
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #410, #674.
I’m going to bed now 😄 .
Haven’t actually tried it yet so if it doesn’t work, @fson feel free to polish & fix it.