-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openBrowser() causes docker-compose set ups to fail because of spawn EACCESS #711
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
…EACCESS - closes facebook#710 Signed-off-by: Aeneas Rekkas (arekkas) <aeneas@ory.am>
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks! |
Awesome, thanks for merging @gaearon ! |
@gaearon any chance this could make it in the 0.4.4 release as it's only a bug fix with no bc or other side effects? |
I plan to release 0.5.0 today. I likely won't have the time to do two releases today so I hope it won't be too much of an inconvenience to you. |
Ah awesome! I thought the 0.5.0 release would be some way further down the road because I saw 0.4.3 and 0.4.4 lined up. That will be aboslutely fast enough :) Thanks for the uber quick responses! |
…EACCESS (facebook#711) * openBrowser() causes docker-compose set ups to fail because of spawn EACCESS - closes facebook#710 Signed-off-by: Aeneas Rekkas (arekkas) <aeneas@ory.am> * Ignore errors
closes #710