-
-
Notifications
You must be signed in to change notification settings - Fork 27k
Make allow customize /dist
naming from consumer's package.
#7172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make allow customize /dist
naming from consumer's package.
#7172
Conversation
- get all matched `npm_package` env's variable; - update default naming schema; - use updated schema in webpack config factory;
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I am not seeing this as being useful for anyone else so we'll likely not go for this. What is your use case for requiring custom naming? |
In my opinion there are various use cases that required custom naming.
I'm would not to do
Perhaps exists other approach for the same thing, would you like to apoint me? |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
We have discussed a config file for CRA in the past, but for now we have decided that it's not a priority @Kyr. As @bugzpodder stated, I'm also concerned that this has little value for most users. Like you, I need this for a project I work on, and we also use a custom fork of Thanks for your time, and in future, I'd suggest raising an issue before a PR so we can discuss it in more detail there :) |
Motivation.
For the some reasons I would to have ability to customize naming in
/dist
.postbuild
script approach not very comfortable and needs an appropriate modification of manifestos.This approach use optional naming schema configuration in consumer's
package.json
, for example "flat" structure:Such config applied to default naming schema and then used in webpack's config factory.