Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version of @typescript-eslint/* #7540

Merged
merged 3 commits into from
Sep 11, 2019
Merged

Bump version of @typescript-eslint/* #7540

merged 3 commits into from
Sep 11, 2019

Conversation

pierreneter
Copy link
Contributor

@pierreneter pierreneter commented Aug 15, 2019 •
edited by ianschmitz
Loading

This PR will close #7529

@pierreneter
Copy link
Contributor Author

Can resolve eslint/eslint#12093 from this PR.

@pierreneter pierreneter mentioned this pull request Aug 18, 2019
Closed
@SamChou19815 SamChou19815 mentioned this pull request Aug 28, 2019
Merged
4 tasks
@Svish
Copy link

Svish commented Sep 3, 2019

... any progress on getting this fix released? 🤔

@CodingDive
Copy link

I had to upgrade to Eslint v6 and some packages were already using v2 of @typescript-eslint. Since react-scripts is still on the old version, I'm getting one eslint error per file saying Definition for rule '@typescript-eslint/no-angle-bracket-type-assertion' was not found.

Hoping for a quick release as Eslint is unusable for me for the time being 🙏

@jonathas
Copy link

jonathas commented Sep 3, 2019

@ReasonableDeveloper Same case for me

@vcanales
Copy link

vcanales commented Sep 5, 2019

+1, necessary to fix issues coming from this: typescript-eslint/typescript-eslint#863

@neilbryson
Copy link
Contributor

@CodingDive : You could add "@typescript-eslint/no-angle-bracket-type-assertion": "off" for the time being

@pierreneter
Copy link
Contributor Author

@ianschmitz please review.

ianschmitz
ianschmitz suggested changes Sep 9, 2019
View reviewed changes
packages/eslint-config-react-app/index.js Outdated Show resolved Hide resolved
packages/react-scripts/package.json Outdated Show resolved Hide resolved
@ianschmitz ianschmitz self-assigned this Sep 9, 2019
@ianschmitz ianschmitz added this to the 3.1.2 milestone Sep 9, 2019
@Siyfion
Copy link

Siyfion commented Sep 10, 2019 •
edited
Loading

This looks great @pierreneter! I've been keeping users at TS 3.5.3 due to typescript-estree not supporting the later versions officially. It'll be good to let people upgrade and use the new features without worry! 😄

@ianschmitz ianschmitz merged commit b3f8ef2 into facebook:master Sep 11, 2019
@ianschmitz
Copy link
Contributor

Thanks! 😃

@lock lock bot locked and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SamChou19815 SamChou19815 SamChou19815 left review comments

@ianschmitz ianschmitz ianschmitz requested changes

@rogerclotet rogerclotet rogerclotet approved these changes

@bugzpodder bugzpodder Awaiting requested review from bugzpodder

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees

@ianschmitz ianschmitz

Labels
CLA Signed tag: underlying tools
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

Upgrade typescript-eslint to v2