Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment.md with another AWS example #7616

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

AndrewBestbier
Copy link
Contributor

Hi there,

I recently wrote a long blog post that takes a React developer step-by-step through many features of AWS. I really think any beginner could follow the guide and have a production ready workflow. Please let me know if my addition is suitable for this page and thank you for all the awesome work you do.

Hi there,

I recently wrote a long blog post that takes a React developer step-by-step through many features of AWS. I really think any beginner could follow the guide and have a production ready workflow. Please let me know if my addition is suitable for this page and thank you for all the awesome work you do.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@AndrewBestbier
Copy link
Contributor Author

@iansu or @amyrlam is this not suitable?

@amyrlam
Copy link
Contributor

amyrlam commented Sep 17, 2019

@AndrewBestbier sorry for the delay!

Looks good to me - @iansu ok with you? Haven't been active lately - ok to approve and merge with the failing Azure tests?

@iansu
Copy link
Contributor

iansu commented Sep 17, 2019

Looks good. Don't worry about the failing tests.

Copy link
Contributor

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amyrlam amyrlam added this to the 3.1.2 milestone Sep 17, 2019
@amyrlam
Copy link
Contributor

amyrlam commented Sep 17, 2019

thanks @iansu!

@amyrlam amyrlam merged commit a1afaa6 into facebook:master Sep 17, 2019
@lock lock bot locked and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants