Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set output.globalObject to 'this' #7742

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Conversation

kentcdodds
Copy link
Contributor

Closes #7741

Verified that this works locally. See #7741 for screenshots/context.

@iansu
Copy link
Contributor

iansu commented Sep 26, 2019

I had made this change in an older WebWorker PR but we never did merge it. We're still working on adding built in support for WebWorkers but this seems like a good way to let people use them in the meantime.

@iansu
Copy link
Contributor

iansu commented Sep 26, 2019

I'm not sure why all of our Windows tests are failing but it's not related to this change.

@iansu iansu added this to the 3.1.3 milestone Sep 26, 2019
@iansu iansu merged commit 42ee721 into facebook:master Sep 26, 2019
@iansu
Copy link
Contributor

iansu commented Sep 26, 2019

Thanks!

@kentcdodds kentcdodds deleted the patch-1 branch September 26, 2019 22:36
@kentcdodds
Copy link
Contributor Author

Thank you! Where can I learn about when this will get released?

@iansu
Copy link
Contributor

iansu commented Sep 26, 2019

We don't really have a firm date for 3.1.3 but I would guess sometime next week. There are a couple other PRs that would be good to get in before we shift over to working on 3.2.

@iansu
Copy link
Contributor

iansu commented Sep 26, 2019

If you want to know when the release happens follow me on Twitter. I always announce releases there. 😀

hchiam added a commit to hchiam/create-react-app that referenced this pull request Sep 27, 2019
set output.globalObject to 'this' (facebook#7742)
@lock lock bot locked and limited conversation to collaborators Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set output.globalObject to this
3 participants