Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong letter casing #7752

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Fix wrong letter casing #7752

merged 1 commit into from
Sep 30, 2019

Conversation

lewislbr
Copy link
Contributor

Just a small correction of the variable name casing, to match the use in the file of filename as a single word.

@mrmckeb
Copy link
Contributor

mrmckeb commented Sep 30, 2019

Hi @lewislbr, while I personally would have written fileName, it's something that's quite arguable...

https://english.stackexchange.com/questions/5366/which-is-correct-filename-file-name-or-filename

@lewislbr
Copy link
Contributor Author

Hey @mrmckeb, I prefer fileName too, I just used filename as it seemed the standard in the file. We could use fileName for all variable names instead.

@mrmckeb mrmckeb added this to the 3.2 milestone Sep 30, 2019
Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, let's merge.

@mrmckeb mrmckeb merged commit fefd716 into facebook:master Sep 30, 2019
@mrmckeb
Copy link
Contributor

mrmckeb commented Sep 30, 2019

Thanks for your help!

@lewislbr
Copy link
Contributor Author

Nice, you're welcome!

@ianschmitz ianschmitz modified the milestones: 3.2, 3.1.3 Oct 1, 2019
@lock lock bot locked and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants