Skip to content

added working bit.ly links to serviceWorker.ts #7887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

added working bit.ly links to serviceWorker.ts #7887

wants to merge 2 commits into from

Conversation

cindyorangis
Copy link

This PR is to fix #7886 . The https://bit.ly/CRA-PWA links lead to 404 Page Not Found. I added a different bit.ly link that leads to https://create-react-app.dev/docs/making-a-progressive-web-app/

@facebook-github-bot
Copy link

Hi cindyledev! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@andriijas
Copy link
Contributor

Nice catch!

Can you update the PR to use the real link? Lets ditch bit.ly at all so the user can see where they will be taken.

Thanks

@andriijas andriijas added this to the 3.3 milestone Oct 29, 2019
@iansu
Copy link
Contributor

iansu commented Oct 29, 2019

We have a new domain name that we're going to be using for shortlinks. We're just waiting on Facebook Open Source to set up the DNS for it. This also doesn't solve the problem for existing apps that contain the broken link.

@cindyorangis
Copy link
Author

Once the DNS is up and the shortlinks are provided, would you like me to add the links manually to the existing apps?

@elbourki
Copy link

elbourki commented Nov 7, 2019

These files need to be updated as well:
packages/cra-template-typescript/template/src/index.tsx
packages/cra-template/template/src/serviceWorker.js
packages/cra-template/template/src/index.js

The link apparently still gets traffic (https://bitly.com/CRA-PWA+) so it really needs to be updated ASAP.

@ianschmitz ianschmitz modified the milestones: 3.3, 3.4 Dec 5, 2019
@iansu iansu modified the milestones: 3.4, 3.5 Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript template serviceWorker.ts has a dead link
6 participants