Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-scripts): do not redirect served path if request may proxy #8442

Merged
merged 1 commit into from
Feb 8, 2020
Merged

fix(react-scripts): do not redirect served path if request may proxy #8442

merged 1 commit into from
Feb 8, 2020

Conversation

iamandrewluca
Copy link
Contributor

@iamandrewluca iamandrewluca commented Feb 7, 2020

Moved redirect middleware and noopSW middleware in WDS after hook
So proxy, and before proxySetup will take precedence before redirect.

Now when making a fetch request that does not start with serverdPatname will check first the proxy middleware, then will redirect if not a proxy like request.

Related #7259
Closes #8417

Moved redirect middleware and noopSW middleware in WDS after hook
So proxy, and before proxy will take precedence before redirect

Closes #8417
@raix
Copy link
Contributor

raix commented Feb 8, 2020

Awesome work @iamandrewluca !!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants