-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimal template #8649
Add minimal template #8649
Conversation
Thanks @nickmccurdy. We have definitely talked about doing this before, and it was one of the motivating factors behind CRA templates. I'm interested in @ianschmitz and @iansu's thoughts on this. |
Yeah I know @iansu and I talked about this as well. Seems reasonable! |
For what it's worth, I'm aware that his |
Yeah we had already claimed |
I'd personally like to avoid adding more templates directly to Create React App. We already have issues with maintaining the JavaScript and TypeScript templates. This is exactly why we added external templates. |
Personally I’m more interested in having a template named minimal than having it be in this repo. Would you be interested in moving this into a separate package of yours (or maybe renaming the empty template as I feel minimal is more fitting)? Alternatively if you don’t mind giving me the name I’d be happy to publish this myself. |
We actually talked about this a few weeks ago and I was just going to publish the "empty" template under that name for both JavaScript and TypeScript. The "empty" name came out of tweet at some point but I think minimal is a better name. |
Is there anything I could help out with? Like extracting a repo of this PR, renaming your existing repo, etc |
I've published a set of minimal templates: https://github.com/iansu/cra-minimal-templates Thanks for your PR but I'm going to close this now. |
Inspired by #6270, this adds a
cra-template-minimal
package which uses the bare minimum file structure necessary to function with React (based on the defaultcra-template
). Optional files like tests and assets have been removed so more experienced users can have full control over what's included, while making less assumptions about tech stack.Test Plan
npx create-react-app my-app --template file:packages/cra-template-minimal
start
displaysReact App
without errors or warningsbuild
succeeds and server displaysReact App
without errors or warningstest
shows no tests, and errors in CI as per Jest's defaults