-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove typescript flag and NODE_PATH support #8934
Conversation
62a0707
to
53a6d06
Compare
aeb6808
to
5172040
Compare
templateJsonPath = path.join(templatePath, 'template.json'); | ||
} else { | ||
// TODO: Remove support for this in v4. | ||
templateJsonPath = path.join(appPath, '.template.dependencies.json'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is legacy, and is not related to the templates feature we released.
It was never officially supported and wasn't documented, and was used for internal testing purposes previously.
@@ -125,7 +119,7 @@ module.exports = function( | |||
|
|||
const templatePackage = templateJson.package || {}; | |||
|
|||
// TODO: Deprecate support for root-level `dependencies` and `scripts` in v4. | |||
// TODO: Deprecate support for root-level `dependencies` and `scripts` in v5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't get a minor out with a warning for this, so we will leave it in for v4.
@ianschmitz I'll leave this to you to merge if you think it's good to go - when you have some time ;) |
Looks like some of the builds are failing. |
3736525
to
aa69a30
Compare
Removes support for the
--typescript
initialisation flag and theNODE_PATH
wherebaseUrl
fromjsconfig
ortsconfig
can be used instead.This also removes a number of other small deprecated features tagged with v4.