Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove typescript flag and NODE_PATH support #8934

Merged
merged 3 commits into from
May 29, 2020

Conversation

mrmckeb
Copy link
Contributor

@mrmckeb mrmckeb commented Apr 30, 2020

Removes support for the --typescript initialisation flag and the NODE_PATH where baseUrl from jsconfig or tsconfig can be used instead.

This also removes a number of other small deprecated features tagged with v4.

@mrmckeb mrmckeb modified the milestones: 3.5, 4.0 Apr 30, 2020
@mrmckeb mrmckeb force-pushed the feature/remove-deprecations branch from 62a0707 to 53a6d06 Compare April 30, 2020 06:36
@mrmckeb mrmckeb force-pushed the feature/remove-deprecations branch 2 times, most recently from aeb6808 to 5172040 Compare May 4, 2020 15:24
templateJsonPath = path.join(templatePath, 'template.json');
} else {
// TODO: Remove support for this in v4.
templateJsonPath = path.join(appPath, '.template.dependencies.json');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is legacy, and is not related to the templates feature we released.

It was never officially supported and wasn't documented, and was used for internal testing purposes previously.

@mrmckeb mrmckeb marked this pull request as ready for review May 4, 2020 15:27
@@ -125,7 +119,7 @@ module.exports = function(

const templatePackage = templateJson.package || {};

// TODO: Deprecate support for root-level `dependencies` and `scripts` in v4.
// TODO: Deprecate support for root-level `dependencies` and `scripts` in v5.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't get a minor out with a warning for this, so we will leave it in for v4.

@mrmckeb
Copy link
Contributor Author

mrmckeb commented May 5, 2020

@ianschmitz I'll leave this to you to merge if you think it's good to go - when you have some time ;)

@ianschmitz
Copy link
Contributor

ianschmitz commented May 5, 2020

Looks like some of the builds are failing.

@mrmckeb mrmckeb force-pushed the feature/remove-deprecations branch from 3736525 to aa69a30 Compare May 29, 2020 07:04
@mrmckeb mrmckeb merged commit 285f9cb into master May 29, 2020
@mrmckeb mrmckeb deleted the feature/remove-deprecations branch May 29, 2020 08:12
rfreling pushed a commit to rfreling/create-react-app that referenced this pull request May 30, 2020
victor-travelperk pushed a commit to travelperk/create-react-app that referenced this pull request Jun 8, 2020
@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants