-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow testMatch for jest config #9114
Allow testMatch for jest config #9114
Conversation
Hi @favna! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Failing CI appears unrelated to this PR, as a matter of fact, at time of writing CI is also failing on master.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no reason why this would affect the CI either, sorry you hit that issue.
@ianschmitz I think we can merge this one?
Bah this error in CI is getting old... |
Resolves #8637.
Tested locally with these steps:
cd packages/react-scripts
yarn link
yarn link "react-scripts"
SKIP_PREFLIGHT_CHECKS=true yarn test
testMatch
key topackage.json
Jest configSKIP_PREFLIGHT_CHECKS=true yarn test
againFor further reasoning as to why this option should be added please refer to #8637.