Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured I'd take a stab at #935 since it seemed relatively easy.
I do have a concern though!
I created the plugin in
react-dev-utils
per suggestion in #935, however this resulted in addingwebpack
as a dependency 😱 -- it was listed as a peerDependency previously (which fails to resolve post lerna/lerna#318).Would it be better to implement it in
react-scripts
and addprogress
as a dependency? Or would you rather explore a solution which doesn't useprogress
?edit: read below