Fix react-jsx error #9869
Fix react-jsx error #9869
Conversation
benneq
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Hi @benneq! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
This fix is correct, it really is |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks! |
|
Would it be possible to get a |
|
Wow. What kind of bot army is this? 20 emails from this issue today. Keep the pressure up. Everybody want's a 4.0.1 release! @zaneclaes Would be nice if you had read the whole thread. Then you would have maybe figured out that this was already discussed and fixed in another PR. |
|
@benneq which "whole thread?" There are 5 of them linked from this PR alone (and I assume you don't mean this PR, since I don't see any linked PRs). I'm reviewing them now and I still don't see what you're referring to. I didn't mean to be snarky, but there are obviously many other people just as lost as I am, and I've spent literally hours reading these threads... |
|
I know issue #9868 is long, but there are some comments about "Object.isFrozen" and referenced issues / merge request about "object is not extensible" which then leads to pull request #9921 which fixes the Object.isFrozen stuff. Still we need a new release for 4.0.1 or even a 4.0.0-next.118 would make people happy. The current "workarounds" (I don't want to call 'em like that) are to use 4.0.0-next.98 or version 3.x or manually applying the pull requests to you node_modules folder. I don't know why facebook makes a new major release with major bugs and then it takes over 4 weeks to provide an update, which could be done with a single click. I mean: It can't get worse, right? 😆 |
Ah, I did read the discussion — but Github hid the PR in question behind multiple "expand hidden comments" 🙄
Yep — that's what I documented in my linked comment, as well 😉
Indeed. I try not to hate on OSS when I know how much work it is, but having a "stable" version of such a widely used tool leave dozens of devs dead-in-the-water for weeks on end is... frustrating. I've definitely lost at least one full day of work to this :sigh: |
|
I downgraded to version "4.0.0-dev.20200803" and solved my problem. #9868
You can now view 05-primeiro-projeto-react in the browser. |
|
Is there a released version that includes this fix? |
|
@cseas looks like it was just released |
While it would be great to update to the latest version of React and all its tooling, there seems to be an issue with typescript versions, react-scripts and the new JSX transform wreaking havoc on the JSX checks. While the issue was supposedly fixed here (facebook/create-react-app#9869), upgrading to react-scripts 4.0.1 doesn't fix the problem. Neither does upgrading AND pinning typescript to 4.0.5 so it doesn't overwrite the tsconfig.json file. Let's wait a few versions ahead for react-scripts so we can be sure this is fixed.
* console: add action pagination + cosmetic changes * Add formatting for permissions section * chore: remove unnecesary console log * console: small improvements to links and general views * Cosmetic enhancements a-la contraktor * Add permissions filtering * Increase delay for actions scheduled * Handle token approvals * Console demo statte * Sort actions, show human readable execution time * Fix linting / tooling * Remove logging * tooling: revert to React, React DOM & React scripts pre-React 17 While it would be great to update to the latest version of React and all its tooling, there seems to be an issue with typescript versions, react-scripts and the new JSX transform wreaking havoc on the JSX checks. While the issue was supposedly fixed here (facebook/create-react-app#9869), upgrading to react-scripts 4.0.1 doesn't fix the problem. Neither does upgrading AND pinning typescript to 4.0.5 so it doesn't overwrite the tsconfig.json file. Let's wait a few versions ahead for react-scripts so we can be sure this is fixed.
Fixed an issue that prevented TypeScript apps from starting #9868 9868