Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: revisit dependency pinning #9933

Closed
wants to merge 3 commits into from

Conversation

ehsankhfr
Copy link
Contributor

@ehsankhfr ehsankhfr commented Oct 28, 2020

Fix #6756, it includes the following:

  • Revisiting all the dependencies in react-script, and removing the followings:
    1. jest-resolve: listed by default under jest -> @jest/core
  • Removing babel-jest from preflight check

Also checked the package tree verification function and seems it works fine with the carrot signed versions

@ehsankhfr ehsankhfr changed the title ISSUE-6756 Revisiting pinned dependencies Fix #6756 Oct 29, 2020
@ehsankhfr ehsankhfr changed the title Fix #6756 Fix: revisit dependency pinning Nov 1, 2020
@stale
Copy link

stale bot commented Dec 19, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 19, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@stale stale bot closed this Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit dependency pinning
3 participants