fix(v2): script tags should allow unknown values (#3385)

#3378
facebook · Sep 1, 2020 · 0d018a8 · 0d018a8
1 parent 5359d61
commit 0d018a8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/docusaurus/src/server/__tests__/configValidation.test.ts b/packages/docusaurus/src/server/__tests__/configValidation.test.ts
@@ -42,6 +42,7 @@ describe('normalizeConfig', () => {
  src: `/analytics.js`,
  async: true,
  defer: true,
+ 'data-domain': 'xyz', // See https://github.com/facebook/docusaurus/issues/3378
  },
  ],
  stylesheets: [

diff --git a/packages/docusaurus/src/server/configValidation.ts b/packages/docusaurus/src/server/configValidation.ts
@@ -77,7 +77,9 @@ const ConfigSchema = Joi.object({
  src: Joi.string().required(),
  async: Joi.bool(),
  defer: Joi.bool(),
- }),
+ })
+ // See https://github.com/facebook/docusaurus/issues/3378
+ .unknown(),
  ),
  stylesheets: Joi.array().items(
  Joi.string(),