encapsulate hacky isDocsPluginEnabled in docsUtils

facebook · Oct 12, 2020 · 15424bb · 15424bb
1 parent 80d1fba
commit 15424bb
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/packages/docusaurus-theme-classic/src/theme/hooks/useDocs.ts b/packages/docusaurus-theme-classic/src/theme/hooks/useDocs.ts
@@ -13,10 +13,8 @@
 // note: warning can be filtered: https://github.com/facebook/docusaurus/pull/3382#issuecomment-684966924
 try {
   module.exports = require('@theme-init/hooks/useDocs');
-  exports.docsPluginEnabled = true;
 } catch (e) {
   module.exports = {};
-  exports.docsPluginEnabled = false;
 }
 
 /*

diff --git a/.../docusaurus-theme-classic/src/utils/docsPreferredVersion/DocsPreferredVersionProvider.tsx b/.../docusaurus-theme-classic/src/utils/docsPreferredVersion/DocsPreferredVersionProvider.tsx
@@ -13,8 +13,10 @@ import React, {
   useState,
 } from 'react';
 import useThemeConfig, {DocsVersionPersistence} from '../useThemeConfig';
+import {isDocsPluginEnabled} from '../docsUtils';
+
+import {useAllDocsData} from '@theme/hooks/useDocs';
 
-import {docsPluginEnabled, useAllDocsData} from '@theme/hooks/useDocs';
 import DocsPreferredVersionStorage from './DocsPreferredVersionStorage';
 
 type DocsPreferredVersionName = string | null;
@@ -132,7 +134,7 @@ export default function DocsPreferredVersionContextProvider({
 }: {
   children: ReactNode;
 }) {
-  if (docsPluginEnabled) {
+  if (isDocsPluginEnabled) {
     return (
       <DocsPreferredVersionContextProviderUnsafe>
         {children}

diff --git a/packages/docusaurus-theme-classic/src/utils/docsUtils.ts b/packages/docusaurus-theme-classic/src/utils/docsUtils.ts
@@ -0,0 +1,11 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+import {useAllDocsData} from '@theme/hooks/useDocs';
+
+// TODO not ideal, see also "useDocs"
+export const isDocsPluginEnabled: boolean = !!useAllDocsData;